[SYCL] Refactor vector_arith*
#16349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR separates the "base" case functional implementation from templates/overloads/constraints. The latter doesn't match even the current SYCL spec and that is not taking into account proposed vec/swizzle changes. Making this change would allow to share more code between non-preview/preview implementation paths when implementing proposed SYCL vec/swizzle changes.
aelovikov-intel
requested review from
cperkinsintel,
uditagarwal97 and
steffenlarsen
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| std::is_same_v<element_type, ext::oneapi::bfloat16>) { | ||
| result_t res{}; | ||
| for (size_t i = 0; i < N; ++i) | ||
| if constexpr (is_logical) |
There was a problem hiding this comment.
could you remind me why we are using -1 on the logical ops here? Or maybe insert a comment?
There was a problem hiding this comment.
Because that's how it's defined in the SYCL spec... ¯\(ツ)/¯
I'm doing some minor changes here to unify several code paths and fix some CTS failures.
| for (size_t I = 0; I < NumElements; ++I) { | ||
| Ret[I] = bit_cast<int8_t>(Ret[I]) != 0; | ||
| } | ||
| return VecOperators::apply_unary_op<std::bit_not<void>>(Rhs); |
There was a problem hiding this comment.
omg, if true, I love this. Stupid operator~ was as huge pain. we need to make sure it's fully tested, lin/win , bool, std::byte (and not applicable to float IIRC).
There was a problem hiding this comment.
I'm running local CTS (bin/test_vector* tests) in addition to pre-commit CI.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the "base" case functional implementation from templates/overloads/constraints. The latter doesn't match even the current SYCL spec and that is not taking into account proposed vec/swizzle changes.
Making this change would allow to share more code between non-preview/preview implementation paths when implementing proposed SYCL vec/swizzle changes.